fix(ci) Clean up Windows artifacts, installer, LLVM etc. #2112 #2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been commented by error, see #2008 (comment).
This patch also removes useless `id` for most steps in the `release` job.
As @jubianchi pointed out, the `wasmer-windows.exe` file is automatically downloaded from https://github.com/wasmerio/wasmer-install/blob/7ef01146fdd7a2ae2840c27905d7d77a7d8c79ba/install.ps1#L42. We don't want to break that. Let's keep it as is.
syrusakbary
approved these changes
Feb 11, 2021
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 11, 2021
2116: fix(ci) Clean up Windows artifacts, installer, LLVM etc. #2112 r=Hywan a=Hywan (re-edit of #2112) # Description 1. 7ff16b4, First, we need to use our own LLVM built for Windows. This has been commited by error, see #2008 (comment). 2. 3946f3c, Second, we copy the `ATTRIBUTIONS` and `LICENSE` files twice. That's useless :-). 3. efff2c8 , Third, as discussed with @MarkMcCaskey, we want to rename `wasmer-windows.exe` to `wasmer-windows-installer.exe` for the sake of clarity. 4. 1a03e88, Fourth, let's create a `wasmer.tar.gz` archive for Windows. 5. 67e8679, Fiveth, let's upload the `wasmer.tar.gz` archive for Windows. 6. cf0c56c, Use `wasmer.zip` on Windows because it's difficult to untar+ungzip on this OS (as discused with @MarkMcCaskey). # Review - [ ] ~Add a short description of the the change to the CHANGELOG.md file~ not necessary Co-authored-by: Ivan Enderlin <[email protected]>
jubianchi
approved these changes
Feb 11, 2021
|
Build failed: |
`github.workspace` uses `\` for the path separator. It creates confusion in Bash. This patch just uses the `.llvm` directory to contain LLVM, and use `pwd` to get an absolute path for `LLVM_SYS_110_PREFIX` and `PATH`.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 11, 2021
2116: fix(ci) Clean up Windows artifacts, installer, LLVM etc. #2112 r=Hywan a=Hywan (re-edit of #2112) # Description 1. 7ff16b4, First, we need to use our own LLVM built for Windows. This has been commited by error, see #2008 (comment). 2. 3946f3c, Second, we copy the `ATTRIBUTIONS` and `LICENSE` files twice. That's useless :-). 3. efff2c8 , Third, as discussed with @MarkMcCaskey, we want to rename `wasmer-windows.exe` to `wasmer-windows-installer.exe` for the sake of clarity. 4. 1a03e88, Fourth, let's create a `wasmer.tar.gz` archive for Windows. 5. 67e8679, Fiveth, let's upload the `wasmer.tar.gz` archive for Windows. 6. cf0c56c, Use `wasmer.zip` on Windows because it's difficult to untar+ungzip on this OS (as discused with @MarkMcCaskey). # Review - [ ] ~Add a short description of the the change to the CHANGELOG.md file~ not necessary Co-authored-by: Ivan Enderlin <[email protected]>
|
Build failed: |
This reverts commit 7ff16b4.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 11, 2021
2116: fix(ci) Clean up Windows artifacts, installer, LLVM etc. #2112 r=Hywan a=Hywan (re-edit of #2112) # Description 1. ~7ff16b4, First, we need to use our own LLVM built for Windows. This has been commited by error, see #2008 (comment) Our LLVM built aren't designed for mingw32. Let's keep LLVM from Choco for the moment. 2. 3946f3c, Second, we copy the `ATTRIBUTIONS` and `LICENSE` files twice. That's useless :-). 3. ~efff2c8 , Third, as discussed with @MarkMcCaskey, we want to rename `wasmer-windows.exe` to `wasmer-windows-installer.exe` for the sake of clarity.~ It will break the Wasmer installer, so let's keep that name as is. 4. 1a03e88, Fourth, let's create a `wasmer.tar.gz` archive for Windows. 5. 67e8679, Fiveth, let's upload the `wasmer.tar.gz` archive for Windows. 6. cf0c56c, Use `wasmer.zip` on Windows because it's difficult to untar+ungzip on this OS (as discused with @MarkMcCaskey). # Review - [ ] ~Add a short description of the the change to the CHANGELOG.md file~ not necessary Co-authored-by: Ivan Enderlin <[email protected]>
|
Build failed: |
are you kidding me… :-@ |
This reverts commit cf0c56c.
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(re-edit of #2112)
Description
7ff16b4, First, we need to use our own LLVM built for Windows. This has been commited by error, see Improved Apple Silicon & LLVM 11 support #2008 (comment).Our LLVM built aren't designed for mingw32. Let's keep LLVM from Choco for the moment.ATTRIBUTIONSandLICENSEfiles twice. That's useless :-).efff2c8 , Third, as discussed with @MarkMcCaskey, we want to renameIt will break the Wasmer installer, so let's keep that name as is.wasmer-windows.exetowasmer-windows-installer.exefor the sake of clarity.wasmer.tar.gzarchive for Windows.wasmer.tar.gzarchive for Windows.wasmer.zipon Windows because it's difficult to untar+ungzip on this OS (as discused with @MarkMcCaskey).Review
Add a short description of the the change to the CHANGELOG.md filenot necessary